Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug. #134719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to elastic#132035 Relates to ES-12649
elasticsearchmachine
added
v9.2.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Sep 15, 2025
| private static Set<String> filter = Set.of("WARNING: Using incubator modules: jdk.incubator.vector"); | ||
|
|
||
| private static boolean isFilteredOut(String line) { | ||
| if (filter.contains(line)) { |
There was a problem hiding this comment.
How about making the filter a predicate? then we can still have one set of filters, instead of some in the set and some in here manually
There was a problem hiding this comment.
@rjernst how about just using the Regex util? Or do you have concerns using something that eventually depends on Lucene? Alternatively the simple predicate below?
/** Messages / lines predicate to filter from the output. */
private static Predicate<String> filter = line -> {
return "WARNING: Using incubator modules: jdk.incubator.vector".equals(line)
|| (line.startsWith("WARNING: Use of the three-letter time zone ID")
&& line.endsWith("is deprecated and it will be removed in a future release"));
};
mosche
added
auto-backport
|
kind ping @rjernst, could you review again |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Sep 18, 2025
elastic#134719) Relates to elastic#132035 Relates to ES-12649
This was referenced Sep 18, 2025
Merged
Merged
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Sep 18, 2025
elastic#134719) Relates to elastic#132035 Relates to ES-12649
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Sep 18, 2025
elastic#134719) Relates to elastic#132035 Relates to ES-12649
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Sep 18, 2025
elastic#134719) Relates to elastic#132035 Relates to ES-12649
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Sep 18, 2025
* upstream/main: (43 commits) Unmute testAckedIndexing to see if it still fails on main (elastic#134682) Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug. (elastic#134719) Adding a getUnmodifiableSourceAndMetadata() method to IngestDocument (elastic#134816) Mark the create-index-from-source action as publicly available on Serverless (elastic#134953) ESQL: Rename command from INLINESTATS to INLINE STATS (elastic#134827) Document multi index query support for simplified retrievers (elastic#134980) [ML] Fix YAMl test to use correct query parameter type (elastic#134999) [Transform] Wait for PIT to close (elastic#134955) Add XPath to XmlUtils (elastic#134923) Fixing conditional processor mutability bugs (elastic#134936) [Transform] Lower loglevel of 3 transform-related error messages from ERROR to WARN (elastic#134985) Unmute pattern text tests. (elastic#134981) Integrate weights into simplified RRF retriever syntax (elastic#132680) Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:stats.CountDistinctWithConditions} elastic#134993 Update periodic java-ea build to test java 26 pre-release (elastic#134983) Mute org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT test {csv-spec:stats.CountDistinctWithConditions} elastic#134984 Fix and unmute testIndexSettingProviderPrivateSetting (elastic#134861) Add missing common cat params (elastic#134870) Support querying multiple indices with the simplified RRF retriever (elastic#134822) Allow including semantic field embeddings in _source (elastic#134717) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug.
On JDK 25 log4j2 2.19 is triggering deprecation warnings due to the initialization of FastDateParser accessing deprecated time zones when iterating over all known time zone IDs. FastDateParser wasn't even used and got removed entirely in log4j 2.22.0.
Relates to #132035
Relates to ES-12649